This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] 4.0 fix for libstdc++/23871
On Wed, Sep 14, 2005 at 10:51:00PM +0200, Paolo Carlini wrote:
> Janis Johnson wrote:
>
> >>I would suggest simply adding the testcases that originally went in
> >>together with those bits of the patch. In other terms,
> >>testsuite/27_io/basic_ostream/inserters_arithmetic/char/7.cc and
> >>testsuite/27_io/basic_ostream/inserters_arithmetic/wchar_t/7.cc
> >>(actually the bits for long and long long should pass already, please
> >>double check).
> >>
> >>
> >Both of those tests already pass with the 4.0 branch, but the new test
> >fails without the patch and passes with it.
> >
> >
> Janis, this is impossible, sorry. Please check again, carefully:
Sorry, I was running the tests by hand outside of the testsuite and
_GLIBCXX_ASSERT was not set. With that set, the tests fail for 4.0 with
and without my patch, so apparently the tests require parts of the patch
that I did not backport; my patch has only the changes to std_ostream.h,
which are needed to allow the PR's test case to compile.
Would it be appropriate to backport the entire patch to 4.0, or does it
change behavior in ways that would break code that currently works with
4.0?
Janis