This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [4.2 PATCH]: PRs 6123 & 18382, centralize defining __PIC__/__pic__


On Mon, Sep 05, 2005 at 10:26:46PM -0400, Kaveh R. Ghazi wrote:
> @@ -419,6 +419,11 @@ c_cpp_builtins (cpp_reader *pfile)
>      cpp_define (pfile, "__FINITE_MATH_ONLY__=1");
>    else
>      cpp_define (pfile, "__FINITE_MATH_ONLY__=0");
> +  if (flag_pic)
> +    {
> +      builtin_define_with_int_value ("__pic__", flag_pic);
> +      builtin_define_with_int_value ("__PIC__", flag_pic);
> +    }

Not ok, because you're not preserving...

> -      if (flag_pic)				\
> -	{					\
> -	  builtin_define ("__pic__");		\
> -	  if (flag_pic > 1)			\
> -	    builtin_define ("__PIC__");		\
> -	}					\

... this distinction between -fpic and -fPIC.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]