This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix objc/23709, error recovery for method's prototype



On Sep 3, 2005, at 10:35 PM, Neil Booth wrote:


Andrew Pinski wrote:-

+      c_token *token = c_parser_peek_token (parser);
+      if ((token->type == CPP_SEMICOLON || token->type == CPP_PLUS
+           || token->type == CPP_PLUS
+	   || (token->type == CPP_KEYWORD && RID_AT_END))
+	  && !nesting_depth)

There seems to be some redundancy here.

The comment above the function is correct, just the code is wrong. I had messed up the code for some reason. Anyways, the second CCP_PLUS should have been CCP_MINUS and "RID_AT_END" should have been "token->keyword == RID_AT_END" as mentioned by JSM.

I will post a new patch after testing but it should not effect the testsuite
as we don't test this code that well.


Sorry about that,
Andrew Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]