This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH: PR 21687


> 
> 
> We were missing ggc_push_context calls around functions in local
> classes; we want to collect within those functions, but we have local
> state that is not in GC roots.  Someone else had tried to fix this
> before with a change that acknowledged itself as a hack; not only did
> the hack not work, but it was probably actively dangerous, as we use
> function_depth for other things....
> 
> Tested on x86_64-unknown-linux-gnu, applied on the mainline and on the
> 4.0 branch..

And this breaks the zone allocator because the zone allocator does not
have push/pop context because they were not used in 4.0.0 at all.

-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]