This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix pr23575 testcase on x86-64


Jakub Jelinek <jakub@redhat.com> writes:

> On Mon, Aug 29, 2005 at 06:45:24AM +0200, Andreas Jaeger wrote:
>> 	* gcc.target/i386/pr23575.c: Run only on 32-bit x86.
>> 
>> ============================================================
>> Index: gcc/testsuite/gcc.target/i386/pr23575.c
>> --- gcc.target/i386/pr23575.c	27 Aug 2005 12:04:28 -0000	1.1
>> +++ gcc.target/i386/pr23575.c	29 Aug 2005 04:43:49 -0000
>> @@ -1,5 +1,6 @@
>>  /* { dg-do compile } */
>>  /* { dg-options "-march=pentium4 -O2" } */
>> +/* { dg-require-effective-target ilp32 } */
>
> As the testcase ought to work just fine with -m64, IMHO it would be much
> better to:

I see.

> /* { dg-options "-O2" } */
> /* { dg-options "-march=pentium4 -O2" { target ilp32 } } */
>
> Or, just:
> /* { dg-options "-msse2 -O2" } */
> (I have verified the testcase ICEs unfixed compiler on both -m32 and -m64
> in that case).

Will you make either change?  I would prefer the later if that works
everywhere (the question is whether it works on i386 systems),

thanks,
Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]