This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, gfortran] Re: Cray Pointers


Asher Langton wrote:
> 	* parse.c: Added do...while(0) and braces around match() 
> macro to avoid the if/else
> 	ambiguity

I'm committing this part of the patch as obvious after the obligatory testing.
 It is no longer needed for your patch, but it certainly makes the code easier
to maintain.  Alas, I've not yet had time to give the rest of your patch a
thorough review because I first had to verify that today's building troubles
are not due to a local problem, and then find a workaround, before I oculd try
a few things with your code.

>From what I've seen from a glance over your patch is that it still contains a
number of formatting errors and includes the patch for the BYTE type.  While
easily resolved these issues put unnecessary burden on the person committing
the patch into CVS, but since we'll have to wait for the legal smoke to clear,
it's no problem right now.

Regards,
- Tobi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]