This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] fix tree-optimization PRs: 22543 and 22228
- From: Dorit Naishlos <DORIT at il dot ibm dot com>
- To: Steven Bosscher <stevenb at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 14 Aug 2005 17:26:44 +0300
- Subject: Re: [patch] fix tree-optimization PRs: 22543 and 22228
> This change is wrong. You can't have a TODO_* flag in the
> properties_required field. You should add it to the flags in
> the todo_flags_finish field. And removing PROP_ssa is also
> wrong. You _do_ need SSA form for the vectorizer.
>
Of course I want SSA-form; I wanted to verify something stronger - that
it's in loop-closed-ssa-form *before* vectorization starts. If there's no
PROP for that, I guess I'll put back the PROP_ssa in 'properties_required'
and maybe add TODO_verify_loops in 'todo_flags_start'?
(anyhow, this is not an inherent part of the patch, i.e., the PR fix is
independent of this change)
thanks,
dorit
Steven Bosscher <stevenb@suse.de> wrote on 14/08/2005 17:16:39:
> On Sunday 14 August 2005 15:56, Dorit Naishlos wrote:
> > *************** struct tree_opt_pass pass_vectorize =
> > *** 209,215 ****
> > NULL, /* next */
> > 0, /* static_pass_number */
> > TV_TREE_VECTORIZATION, /* tv_id */
> > ! PROP_cfg | PROP_ssa, /* properties_required */
> > 0, /* properties_provided */
> > 0, /* properties_destroyed */
> > 0, /* todo_flags_start */
> > --- 209,215 ----
> > NULL, /* next */
> > 0, /* static_pass_number */
> > TV_TREE_VECTORIZATION, /* tv_id */
> > ! PROP_cfg | TODO_verify_loops, /* properties_required */
> > 0, /* properties_provided */
> > 0, /* properties_destroyed */
> > 0, /* todo_flags_start */
>
> This change is wrong. You can't have a TODO_* flag in the
> properties_required field. You should add it to the flags in
> the todo_flags_finish field. And removing PROP_ssa is also
> wrong. You _do_ need SSA form for the vectorizer.
>
> Gr.
> Steven
>