This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] fix tree-optimization PRs: 22543 and 22228


On Sunday 14 August 2005 15:56, Dorit Naishlos wrote:
> *************** struct tree_opt_pass pass_vectorize =
> *** 209,215 ****
>     NULL,                                 /* next */
>     0,                                    /* static_pass_number */
>     TV_TREE_VECTORIZATION,                /* tv_id */
> !   PROP_cfg | PROP_ssa,                  /* properties_required */
>     0,                                    /* properties_provided */
>     0,                                    /* properties_destroyed */
>     0,                                    /* todo_flags_start */
> --- 209,215 ----
>     NULL,                                 /* next */
>     0,                                    /* static_pass_number */
>     TV_TREE_VECTORIZATION,                /* tv_id */
> !   PROP_cfg | TODO_verify_loops,         /* properties_required */
>     0,                                    /* properties_provided */
>     0,                                    /* properties_destroyed */
>     0,                                    /* todo_flags_start */

This change is wrong. You can't have a TODO_* flag in the 
properties_required field.  You should add it to the flags in
the todo_flags_finish field.  And removing PROP_ssa is also
wrong.  You _do_ need SSA form for the vectorizer.

Gr.
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]