This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: add mips long_call attribute


On Fri, 2005-07-29 at 23:52, Richard Sandiford wrote:
> I don't see the need for this.  Why not just check the SYMBOL_REF_DECL
> directly in const_call_insn_operand?

Another point I forgot to mention, checking for the long call attribute
in mips_encode_section_info allows us to do consistency checks there. 
At the moment, there doesn't seem to be anything that it can conflict
with, but I am allowing for the possibility that we might find ones
later, or maybe add things later that might conflict with it, in which
case we may as well put the code there now.

We don't want to do consistency checks inside the
const_call_insn_operand predicate.  It isn't reasonable to do them
there.

I'll admit that doing the long_call attribute check directly in
const_call_insn_operand is a reasonable way to implement this.  I found
at least 3 different ways to implement this feature, and I picked one
that I thought was most reasonable.  It isn't necessary the same one
that you will think is most reasonable.
-- 
Jim Wilson, GNU Tools Support, http://www.specifix.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]