Re: PATCH: other/17466: Testsuites in gcc override LD_LIBRARY_PATH

[Geoff Keating <geoffk at apple dot com>]

On 25/07/2005, at 1:07 PM, H. J. Lu wrote:

> On Mon, Jul 25, 2005 at 12:30:10PM -0700, Geoff Keating wrote:
>
> > Hi HJ,
> >
> >
> > > 2004-09-13  H.J. Lu  <hongjiu.lu@intel.com>
> > >
> > >        PR other/17466:
> > >        * lib/gcc-defs.exp (${tool}_set_ld_library_path): New
> > > procedure.
> > >        * g++.dg/compat/compat.exp (ld_library_path): Renamed to
> > >        gcc_ld_library_path.
> > >        (compat-fix-library-path): Removed.
> > >        (compat-use-alt-compiler): Call ${tool} 
> > > _set_ld_library_path to
> > >        switch library path.
> > >        (compat-use-tst-compiler): Likewise.
> > >        * lib/g++.exp (g++_link_flags): Don't use global
> > >        ld_library_path. Call ${tool}_set_ld_library_path to set up
> > >        LD_LIBRARY_PATH, SHLIB_PATH, LD_LIBRARYN32_PATH,
> > >        LD_LIBRARY64_PATH, LD_LIBRARY_PATH_32, LD_LIBRARY_PATH_64 and
> > >        DYLD_LIBRARY_PATH.
> > >        * lib/gfortran.exp (gfortran_link_flags): Likewise.
> > >        * lib/objc.exp (objc_target_compile): Likewise.
> > >        * lib/gcc-dg.exp: Call ${tool}_set_ld_library_path to set up
> > >        LD_LIBRARY_PATH, SHLIB_PATH, LD_LIBRARYN32_PATH,
> > >        LD_LIBRARY64_PATH, LD_LIBRARY_PATH_32, LD_LIBRARY_PATH_64 and
> > >        DYLD_LIBRARY_PATH.
> >
> > How did you test this patch?
>
> When I was working on the libunwind change on ia64, the newly built
> libunwind.so.7 wasn't available unless LD_LIBRARY_PATH was handled
> properly. That is how I noticed the problem and tested the patch.

OK.  Please test it thoroughly and report your results.  You need to  
check:

- that in-tree testing still works, and chooses the right libgcc
- that installed testing still works (does not change *_LIBRARY_PATH)
- that remote testing also still works (does not change *_LIBRARY_PATH)

Attachment: smime.p7s
Description: S/MIME cryptographic signature