Re: [PATCH] Bootstrap currently broken due to unsigned comparison warning in calls.c

[Manfred Hollstein <mh at novell dot com>]

On Mon, 25 Jul 2005, 17:59:21 +0200, Jakub Jelinek wrote:
> On Mon, Jul 25, 2005 at 05:38:42PM +0200, Manfred Hollstein wrote:
> > Hi there,
> > 
> > bootstrap is currently broken:
> > 
> >   ../../gcc-20050725/gcc/calls.c: In function 'store_one_arg':
> >   ../../gcc-20050725/gcc/calls.c:4101: warning: comparison between signed and unsigned
> > 
> > This has been introduced by Jakub's patch which is more-or-less a copy
> > of similar code several lines above. The for-loop's termination test is
> > different, though. Assuming that "arg->locate.size.constant" does not
> > carry negative values, the patch below would obviously be correct; I
> > don't know, however, if that assumption is correct.
> 
> Oops, sorry.  Not sure why -Werror has not been used in my bootstrap
> this time, will investigate.
> Anyway, more correct would be probably using unsigned HOST_WIDE_INT k;
> and casting to (unsigned HOST_WIDE_INT).

Thanks. The final patch I just installed is attached.

Cheers.

l8er
manfred

Attachment: GCC.DIFFS
Description: Text document