This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [wwwdocs] optimizer improvements for GCC 4.1 changes.html
On Sunday 24 July 2005 23:52, Gerald Pfeifer wrote:
> Hi Steven,
>
> On Fri, 22 Jul 2005, Steven Bosscher wrote:
> > Time to put something in that page!
>
> that's definitely a good idea! I just got some minor comments. Please
> go ahead an commit your patch after considering these.
>
> > Index: changes.html
> > ===================================================================
> > + <li>GCC now has infrastructure for inter-procedural optimizations.
> > + following inter-procedural optimizations are implemented:<br />
>
> Is there something missing here? (lower-case "following",...)
>
> Perhaps "and the following...have been implemented"?
"The" is missing. "and the" is also fine, I'll just use that.
> > + int foo (int *, int *);
> > + int
> > + main (int argc)
>
> Perhaps call this function differently, since I believe you'll need to
> have char **argv as well if it's the true main()?
Just a copy from the Wiki. I'll change this a bit.
> > + <li>Improvements to peeling for alignment.</li>
>
> Anything more specific you could add?
Nope :-) I have no idea what the old code could handle, or what kind
of capabilities the new code adds.
> > + <li>A new pass optimizes out saving of unneeded arguments to stack in
> > + <code>vararg</code> functions if the compiler can prove that they
> > + will not be needed.</li>
>
> "avoid svaing...to the stack"?
Make it "saving" and I agree.
Thanks for the review.
Gr.
Steven