This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, fortran] Simplify constant substrings


On Fri, 2005-07-22 at 15:35 +0100, Paul Brook wrote:
> On Friday 22 July 2005 14:44, David Edelsohn wrote:
> > >>
> > >> Who implied that it would not?
> >
> > Steven> Your patch didn't and you didn't say you planned to add it to the
> > Steven> test suite.  Nobody can read your mind, you know.
> >
> > 	Testcases for patches are added to the testsuite.  That is a
> > general policy.
> 
> We also require that all patches are properly tested, and it is convention to 
> add ChangeLog entries for new testcases.

Actually, i'm not sure that this part is right (the changelog for
testcases)

Half the people add changelog entries for testcases, half don't.

After all, it's rather obvious you added a testcase, and testcases are
rarely modified, so the changelog entry is somewhat useless.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]