This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re:patch to fix erroneous processing of -o<file.o> option


Hi Uttam,

+2004-08-10 Uttam Pawar <pawar@us.ibm.com>
+
+ * gcc.c (process_command): Added if statement block to handle
+ -o option without a space between an option 'o' and it's argument
+ when used it with another option -pipe in combination.
+

I looked at this patch. I don't think it's correct. I have these areas of concern:


- It seems to be specific to '-o'. There are lots of other joined options, -o is just one of them.

- It appears to be changing the design of gcc.c with respect to the way that joined options are handled, but it only changes one place. Since joined options mostly work now, there must be many other places which still rely on the old design.

I think that a correct patch would either change the design completely, or would preserve the existing design and change the deletion logic to handle joined options properly.

:REVIEWURL http://gcc.gnu.org/ml/gcc-patches/2004-08/msg00784.html :

Attachment: smime.p7s
Description: S/MIME cryptographic signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]