This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH]: Fix PR c++/22452

From: Nathan Sidwell <nathan at codesourcery dot com>
To: Daniel Berlin <dberlin at dberlin dot org>
Cc: Gabriel Dos Reis <gdr at integrable-solutions dot net>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 15 Jul 2005 12:51:44 +0100
Subject: Re: [PATCH]: Fix PR c++/22452
References: <1121380218.12483.54.camel@linux.site>

Daniel Berlin wrote:

This restores the behavior of decl_linkage to what it was before the
decl restructuring patch went in, by not checking DECL_COMDAT on
CONST_DECL (since CONST_DECL's can't be DECL_COMDAT).

If they were ever set to DECL_COMDAT, we'd get a tree check somewhere
else anyway.

Gaby seems to believe the behavior of decl_linkage is wrong in some way
in regard to CONST_DECL.

Okay for mainline?

ok

There really needs to be a later check for const_decls, to return the linkage of their type. I missed that bullet 3.5/4 (bullet 5)

nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::     CodeSourcery LLC
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

Follow-Ups:
- Re: [PATCH]: Fix PR c++/22452
  - From: Nathan Sidwell

References:
- [PATCH]: Fix PR c++/22452
  - From: Daniel Berlin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]