This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: arc profiling broken (Was: [4.1 patch] relocate profile datafile)


Joern RENNECKE wrote:

Yes, we can work it all out in config.gcc. I'm not sure that makes sense, though.
We could work out every single macro in config.gcc, and do away with all
the target config header files, but we'd get a huge mess of spaghetti code.
Is there any reason why TARGET_POSIX_IO would be better set in config.gcc,
rather than the target config files?
We have config files that are generic for a number of OSes, so we don't actually
have to write significantly more code than if we put it in config.gcc. It might
actually be less, since we don't need to have new code to select on the OS and
other features.
As said before, I think replacing the definitions of TARGET_HAS_SETLKW
with definitions of TARGET_POSIX_IO provides a perfect starting point.

I think Joern's proposal is the way to go. HJ, can you prepare a patch?


nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::     CodeSourcery LLC
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]