This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Make CONSTRUCTOR use VEC


Giovanni Bajo wrote:

Another piece of code I forgot to clean up, but thanks for your exhaustive
analysys.
BTW, I don't think removing tsubst_copy at this point is a big effort. I'll
see if I can find a spare week.

excellent!


There is much confusion here, yes, and redundant checks within macros. I
tried cleaning up some of them, but it was not trivial and the patch was
already too big. The first thing I would like to clean up in a follow up
patch is moving compound literals to their own node (COMPOUND_LITERAL_EXPR
for instance) instead of reusing CONSTRUCTORs with a lang flag (which btw,
it's called TREE_HAS_CONSTRUCTOR, to increase the confusion).

ok, clearly something that should be done in a different patch.



The changes to coverage.c are ok too, if you promise to deal with the
fixme's you've put in promptly :)
!   /* FIXME: use build_constructor directly.  */


OK. Is 'make bootstrap && make -k check' enough to test coverage.c? Or will
I need something else?
they should suffice, although you might want to try a profiled bootstrap too.

No prob! BTW, I assume you also consider the vec.h changes ok?
I forgot to look, but given I wrote VEC_copy for you, and you fixed the typo, I think we're ok :) VEC_empty is ok too.

I'll post an updated version of the patch with these C++ fixes in the
weekend when I ping it for review.
Thanks for the review!

nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]