This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix loop location in .vect dump files



On Jun 26, 2005, at 7:31 PM, Roger Sayle wrote:



On Wed, 22 Jun 2005, Devang Patel wrote:


         * tree-vectorizer.h (struct _loop_vec_info): Remove
       loop_line_number.
         (LOOP_VINFO_LOC, LOOP_LOC): Remove.
         (vect_loop_locaation): New.
         * tree-vectorizer.c (vect_loop_location): New.
         (vect_print_dump_info): Use vect_loop_location.
         (new_loop_vec_info): Do not set LOOP_VINFO_LOC.
         (vectorize_loops): Set vect_loop_location.
         * boring entries to remove loc parameter everywhere
         vect_print_dump_info is used ...



This is OK for mainline, provided that you include the appropriate
complete ChangeLog entry for the "boring entries" above, and that
you move

+
+ /* Loop location */
+ extern LOC vect_loop_location;

This change from being a global variable in tree-vectorizer.h to
a static variable in tree-vectorizer.c.  It looks like this is
now only defined and used in that one file, once the API for the
function vect_print_dump_info has been updated.  [If I'm wrong,
I'll blame your sloppy ChangeLog on the incorrect review :)].

You also need to fix the above comment, which should end with a
period/fullstop followed by two spaces before the "*/".  And
finally you should provide the full target triple for the machine
that you bootstapped and regression tested on, which for Darwin
includes the OS version.

Thanks. Finally I have committed this patch. I did another round of bootstrap on powerpc-apple-darwin before final check-in.

-
Devang

Attachment: av_loop_loc.final.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]