This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFH] - Less than optimal code compiling 252.eon -O2 for x86
- From: Fariborz Jahanian <fjahanian at apple dot com>
- Cc: Steven Bosscher <stevenb at suse dot de>, Jeff Law <law at redhat dot com>, Bernd Schmidt <bernds_cb1 at t-online dot de>, "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>
- Date: Fri, 1 Jul 2005 11:18:39 -0700
- Subject: Re: [RFH] - Less than optimal code compiling 252.eon -O2 for x86
- References: <B7C12C01-DBA8-4F56-9DF3-4BE0C45D5ADD@apple.com> <1120155806.4621.233.camel@localhost.localdomain> <DA02021B-4192-42DB-BB1E-D50FAC3D8386@apple.com> <200506302147.15097.stevenb@suse.de> <44CA7C61-D97F-4C52-81B9-3302DF0DEB9C@apple.com>
On Jun 30, 2005, at 2:29 PM, Fariborz Jahanian wrote:
On Jun 30, 2005, at 12:47 PM, Steven Bosscher wrote:
Well, maybe so, but it would be a pretty lame workaround. Why are
you
so worried about bugs? This flag was always disabled at -O1, and we
have never seen any bug reports that got fixed with -fforced-mem.
And
besides, it is better to fix bugs than to work around them.
Making the option a nop, issuing a warning in 4.1 and removing the
option completely for gcc 4.2 looks like a very reasonable
approach to
me.
OK. This seems to be the consensus and I will prepare a patch base
on that.
Here is the patch. Bootstrapped, dejagnu tested on apple-ppc-darwin
and apple-x86 darwin. Couple of tests which use -fforce-mem are twiked.
OK for fsf mainline?
- fariborz
ChangeLog:
2005-07-01 Fariborz Jahanian <fjahanian@apple.com>
* doc/invoke.texi: Update -fforce-mem documentation.
* dojump.c (compare_from_rtx,do_compare_rtx_and_jump): Remove
code for -fforce-mem.
* expmed.c: (store_bit_field,store_fixed_bit_field,
extract_bit_field): Ditto.
* expr.c: (convert_move): Ditto.
* optabs.c:
(expand_binop,expand_twoval_unop,expand_twoval_binop,
expand_unop,emit_unop_insn,prepare_cmp_insn,emit_conditional_move,
emit_conditional_add,expand_float,expand_fix): Ditto.
* opts.c: (decode_options): Remove setting of flag_force_mem
flag.
(common_handle_option): Issue warning when -fforce-mem
specified.
testsuite:/ChangeLog
2005-07-01 Fariborz Jahanian <fjahanian@apple.com>
* gcc.dg/20030324-1.c: Remove -fforce-mem option.
* gcc.dg/980816-1.c: Ditto.
Attachment:
fsf-patch-no-force-mem.txt
Description: Text document
- fariborz