Re: [PATCH] libssp toplevel library

[Richard Henderson <rth at redhat dot com>]

On Tue, Jun 28, 2005 at 01:58:37PM -0400, Jakub Jelinek wrote:
> Or GCC configury could do the checking just for the TLS canary, and
> somehow include libssp.spec (created by libssp's configury).

I kinda like the idea of -fstack-protector including libssp.spec,
and having that define something for inclusion into LINK_COMMAND_SPEC.

> For GNU ld, we could create a GROUP ( libssp.so.0 libssp_nonshared.a )
> libssp.so, but for other linkers I'm afraid there is nothing like that,
> do we want to turn off using __stack_chk_fail_local in that case,
> so that only -lssp is needed and not -lssp -lssp_nonshared?

I don't see this is necessary.  libssp_nonshared.a only ever 
references libssp.a, so there's no reason for anything other
than "-lssp_nonshared -lssp".

> Lastly, I was wondering if libssp wouldn't be the right place
> for adding _FORTIFY_SOURCE support for non-glibc targets
> (basically <stdio.h>, <string.h>, <unistd.h> that would #include_next
> themselves and do the stuff glibc is doing in its headers,
> plus support routines).

That seems like an ok idea.  It'll require more thought in how
to pull in -lssp correctly, wrt the user command-line options.

This patch looks ok.


r~