This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to clean up uses of default_function_array_conversion


On 6/16/05, Richard Guenther <richard.guenther@gmail.com> wrote:
> On 6/16/05, Joseph S. Myers <joseph@codesourcery.com> wrote:
> >
> > This patch changes from having
> >
> >   TREE_SIDE_EFFECTS (adr) = 0;   /* Default would be, same as EXP.  */
> >
> > only for addresses of variables to having it for all array-to-pointer
> > conversions.  This is not safe, since the address of an array can have
> > side effects.  For example, the following test (which should go in
> > gcc.c-torture/execute) passes before your patch but fails with it applied.
> 
> Fixed by re-inserting if (TREE_CODE(exp) == VAR_DECL) before.
> Re-bootstrapped and regtested on i686-pc-linux-gnu, testcase added.
> 
> Ok for mainline?

Andrew kindly pointed out I posted an empty pach file.  Fixed (hopefully).

Richard.

Attachment: canonicalize-array-decay-C-final3
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]