Re: strverscmp for libiberty

[Geoffrey Keating <geoffk at apple dot com>]

On 14/06/2005, at 4:06 PM, DJ Delorie wrote:

> > Any objections?  Did I miss a detail?
>
> You're missing documentation.  And a reason why it's appropriate to
> put this in libiberty, instead of in gcc.  Is there some standard that
> defines this function?  Will anyone else use it besides gcc?

It's a GNU extension.  At this time there's no other user than GCC,  
but there might be other users in the future.  Should I just put it  
in GCC?  It would still need to be a separate file; I guess I would  
call the function gcc_strverscmp so as not to conflict with glibc.

> Also, the file doesn't quite follow FSF coding conventions, and
> doesn't include libiberty.h or config.h nor use any of the HAVE_*
> macros.

I guess it should just include safe-ctype.h.  How doesn't it follow  
FSF coding conventions?

> You should also add code to configure.ac to maybe set the HAVE_DECL_*
> macro for libiberty's own use.

OK, although libiberty does not in fact use it and is not likely to.

How about this?

Attachment: libiberty-strverscmp-1.patch
Description: Binary data

Attachment: smime.p7s
Description: S/MIME cryptographic signature