This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: 4.0.2/4.1 PATCH: Enforce PIC code for mips libffi (PR libgcj/21943)
Richard Sandiford writes:
> Rainer's patch is correct whether we change the specs or not.
> However, gcc -- and the asm files in config/mips/ -- use the
> directive ".abicalls" instead of ".option pic2". I'd prefer
> that we do the same here for consistency. The patch is OK
> with that change.
Thanks, installed on mainline and queued for 4.0.2. Here's the actual
patch I committed.
Rainer
-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University
2005-06-15 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE>
PR libgcj/21943
* src/mips/n32.S: Enforce PIC code.
* src/mips/o32.S: Likewise.
Index: src/mips/n32.S
===================================================================
RCS file: /cvs/gcc/gcc/libffi/src/mips/n32.S,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -p -r1.3 -r1.4
--- src/mips/n32.S 21 Oct 2003 19:01:56 -0000 1.3
+++ src/mips/n32.S 15 Jun 2005 00:10:05 -0000 1.4
@@ -1,5 +1,5 @@
/* -----------------------------------------------------------------------
- n32.S - Copyright (c) 1996, 1998 Red Hat, Inc.
+ n32.S - Copyright (c) 1996, 1998, 2005 Red Hat, Inc.
MIPS Foreign Function Interface
@@ -39,6 +39,7 @@
#define SIZEOF_FRAME ( 8 * FFI_SIZEOF_ARG )
+ .abicalls
.text
.align 2
.globl ffi_call_N32
Index: src/mips/o32.S
===================================================================
RCS file: /cvs/gcc/gcc/libffi/src/mips/o32.S,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -p -r1.6 -r1.7
--- src/mips/o32.S 23 Nov 2004 23:18:11 -0000 1.6
+++ src/mips/o32.S 15 Jun 2005 00:10:05 -0000 1.7
@@ -1,5 +1,5 @@
/* -----------------------------------------------------------------------
- o32.S - Copyright (c) 1996, 1998 Red Hat, Inc.
+ o32.S - Copyright (c) 1996, 1998, 2005 Red Hat, Inc.
MIPS Foreign Function Interface
@@ -37,6 +37,7 @@
#define SIZEOF_FRAME ( 4 * FFI_SIZEOF_ARG + 2 * FFI_SIZEOF_ARG )
+ .abicalls
.text
.align 2
.globl ffi_call_O32