This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Moving some VRP bits from DOM into tree-vrp


On 6/14/05, Jeffrey A Law <law@redhat.com> wrote:
> 
> This is the first in what is sure to be many patches to start to
> move functionality that has been in DOM for historical purposes,
> but really belongs elsewhere.  The long term goal (of course) being
> that DOM transforms itself into a context sensitive jump optimizer
> and little else.

What is the reason for calling local_fold (and thus introducing it)
at the following place instead of using int_const_binop?

                 t = build (BIT_AND_EXPR, TREE_TYPE (op0), op0,
                                   local_fold (build (MINUS_EXPR,
                                                      TREE_TYPE (op1),
                                                      op1,
                                                      integer_one_node)));

As far as I see it could as well (better) read

     t = build2 (BIT_AND_EXPR, TREE_TYPE (op0), op0,
                      fold_convert (TREE_TYPE (op0),
                                            int_const_binop (MINUS_EXPR,
                                                  op1,
                                                  build_int_cst
(TREE_TYPE (op1), 1), 0))));

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]