Re: Patch: RFA: Fix PR java/21844

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Ranjit" == Ranjit Mathew <rmathew@gmail.com> writes:

Ranjit>       /* Before we give up, see whether it is a non-static field
Ranjit>          inherited from the enclosing context we are considering.  */
Ranjit>       if (!DECL_CONTEXT (TYPE_NAME (type_root))
Ranjit>           && !is_static
Ranjit>           && inherits_from_p (type_root, decl_type))
Ranjit>         return 1;
Ranjit>     }

Ranjit> The "if" inside the for loop is a dead statement overridden
Ranjit> by the "continuation condition" of the "for" loop. This was
Ranjit> a rather silly mistake on my part.

Ranjit> So we can either rework that "for" loop, or just remove
Ranjit> that "if" block and take it out of the loop as you have
Ranjit> done in your patch.

Thanks -- I removed the 'if' from the loop and I'm checking in that
variant.

Tom