This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] tree-ssa-ccp.c: Clean up ccp_fold.


On Sun, 29 May 2005, Kazu Hirata wrote:
> 2005-05-29  Kazu Hirata  <kazu@cs.umass.edu>
>
> 	* tree-ssa-ccp.c (ccp_fold): Return immediately after calling
> 	fold_unary and fold_binary.

This is OK for mainline.

Whilst I acknowledge Richard Guenther's concerns that it would be
nice to assert/confirm that fold always returns with the same type
as its argument, such a check belongs in fold-const.c (much like
the current --enable-checking=fold code that verifies that the
input argument's tree is never modified.  I think this is preferable
to potentially scattering a number of identical assertions at
each of fold's call sites.

I'll do some testing to see how close we now are to being completely
pointer equality type-safe.

Roger
--


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]