This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] tree-ssa-ccp.c: Clean up ccp_fold.


On 5/29/05, Kazu Hirata <kazu@cs.umass.edu> wrote:
> Hi,
> 
> Attached is a patch to clean up ccp_fold.
> 

> fold_binary returns a gimple min invariant
> ------------------------------------------
> 
> In this case, we call is_gimple_min_invariant and then call
> fold_convert.  However, the call to fold_convert is useless because
> fold_binary is supposed to produce a tree node of the right type.
                     ^^^^^^^^^^^^^^^
add an assert (and be surprised).  Not that I don't have some patches
that fix some problems in fold, but they need to be updated.  Hopefully
next week.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]