This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add UNARY_PLUS_EXPR to C++ front-end (take 2)


Roger Sayle <roger@eyesopen.com> writes:

| Many thanks to both Mark and Giovanni for suggesting that appropriate
| fix was to fold the new UNARY_PLUS_EXPR in fold_if_not_in_template.
| This indeed fixes the g++ regression.  I also took the opportunity
| to go through and audit all of the uses of CONVERT_EXPR in the cp/
| directory.  I believe I've now caught all the relevant cases and the
| 12 remaining uses of CONVERT_EXPR appear to treat it as a synonym
| for NOP_EXPR.
| 
| The following revised patch has been tested on x86_64-unknown-linux-gnu
| with a full "make bootstrap", all default languages, and regression
| tested with a top-level "make -k check" with no new failures.
| 
| Ok for mainline?

Sorry for not having commented earlier, but I think you need to add
the pretty printing of UNARY_PLUS_EXPR in cxx-pretty-print.c too.

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]