This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran] PR libfortran/21376


*Blush* well, yes.  Reminds me to never have the final look at a patch late at
night :-(  I agree that the patch is the easiest way to do this then, you
should add a testcase for it, though.  The testcase I posted is not good
enough given that I got the exponents of the corner cases wrong.

OK. I will add a testcase.


Another issue is that your patch is only superficially different from the one
Peter Wainwright suggested when he filed the PR, so you should probably add
his name to the ChangeLog entry.

OK, so here is my question: is the name in the ChangeLog entry supposed to be the one of the commiter, the one of the author, or both?


FX


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]