This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: SPARC: minor tweaks

From: Eric Botcazou <ebotcazou@libertysurf.fr>
Date: Tue, 17 May 2005 22:27:59 +0200

> > >    /* Slick... but this trick loses if this subreg constant part
> > >       can be done in one insn.  */
> > > -  if (low == high && (low & 0x3ff) != 0 && low + 0x1000 >= 0x2000)
> > > +  if (low == high
> > > +      && ! SPARC_SETHI32_P (high)
> > > +      && ! SPARC_SIMM13_P (high))
> >
> > SPARC_SIMM13_P() should be run against "low" not "high".
> 
> Stylistically?  The idiom is used in 2 other places like that.

Nevermind, I misread the conditional.
But yes, it would read more cleanly if low was used
with the SIMM13 macro.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]