This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING [PATCH] testsuite: Add new effective target keywords


On Mon, May 16, 2005 at 11:07:15PM +0200, Björn Haase wrote:
> Hello  Janis,
> 
> after having arranged for the legal issues: Here are again the two patches.

Great!  The patches look good, but there are some minor things I'd like
you to fix.

In the ChangeLog entries, use two spaces betwen the date and your name,
and two spaces between your name and your address.

> 1.) new effective target keywords
>
> Index: target-supports.exp
> + # Looks at target_info struct and explicit target list
> + # for finding out whether target is supposed to support
> + # trampolines. In case of missing support return 0.

Keep it simple: "Return 1 if ..."

> +     if {[target_info exists no_trampolines]} {

The curly braces aren't needed here.

> + # Find out whether target defines int to be 
> + # larger than 16 bits and return 1 in this case.

"Return 1 if ..."

> --- 332,338 ----
>   	     || [istarget arm*-*-eabi*]
>   	     || [istarget arm*-*-elf]
>   	     || [istarget arm*-*-symbianelf*]
> +              || [istarget avr-*-*]
>   	     || [istarget powerpc-*-eabi*]
>   	     || [istarget strongarm*-*-elf]
>   	     || [istarget xscale*-*-elf]

Begin the added line with a tab like the surrounding code.

> 2.) adaptions for avr and clean-ups in gcc.c-torture/compile
>
> Index: 20010327-1.c
>      Some rare environments might not have the required relocs to support
> !    this; they should have this test disabled by magic comments.  */
> ! 
> ! /* { dg-xfail-if "hi mode pointer for avr" { "avr-*-*" } { "*" } { "" } } */ 
"They should disable this test."

You're not disabling the test, though, you're saying it's an expected
failure.  If this is a permanent restriction then it ought to be 'skip'
instead of 'xfail'.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]