This is the mail archive of the
mailing list for the GCC project.
Re: Warning fixes for libiberty
- From: Ian Lance Taylor <ian at airs dot com>
- To: Andreas Jaeger <aj at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 16 May 2005 09:48:09 -0400
- Subject: Re: Warning fixes for libiberty
- References: <firstname.lastname@example.org>
Andreas Jaeger <email@example.com> writes:
> The pexecute ones can be fixed with changing the pexecute interface -
> and I'm not sure whether we want that one. The change would be
> something like:
> extern int pexecute (const char *, char * const *, const char *,
> - const char *, char **, char **, int);
> + const char *, char * const *, char * const *, int);
> I could prepare a patch if wanted.
Hmmm. That change would cause warnings for users of pexecute. On the
other hand pexecute has always returned a pointer to a string
constant, so it's always been a requirement for the caller to not
modify the returned string. And of course pexecute is now an obsolete
interface, and code should now call pex_init/pex_run or pex_one. So
I'm on the fence on this. Any other opinions?
> 2005-05-16 Andreas Jaeger <firstname.lastname@example.org>
> * getpwd.c: Remove unneeded prototype getcwd and move getwd so
> that it's only declared if needed.
> * getopt1.c: Change order of includes so that __GNU_LIBRARY__ is
This is OK. Thanks.