This is the mail archive of the
mailing list for the GCC project.
Re: [Ada PATCH] Clean-up Ada front-end use of TREE_OVERFLOW
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>, gcc-patches at gcc dot gnu dot org
- Date: 16 May 2005 04:11:35 +0200
- Subject: Re: [Ada PATCH] Clean-up Ada front-end use of TREE_OVERFLOW
- References: <Pine.LNX.email@example.com>
Roger Sayle <firstname.lastname@example.org> writes:
| On Sun, 15 May 2005, Richard Kenner wrote:
| > Diagnosing these these types of problem in GCC's Ada front-end would be
| > easier if the following patch could be approved (ping?):
| > http://gcc.gnu.org/ml/gcc-patches/2005-05/msg00175.html
| > That needs somebody who knows the pp stuff; it's OK with me if it looks
| > correct to them.
| Hopefully, Gabriel can comment?
I'm sorry for the delay -- the mail went through the crack :-(
The changes look OK, with the caveat that the pretty_printer object
should probably be constructed as part of gnat1 startup
initialization, instead of waiting for the first call to abort where
the compiler is already in a unspeakable state.
The C and C++ front-end, for example, uses a global pretty-printer
object that is initialized in toplev.c:general_init(). I have no idea
whether toplev.c is included in gnat1 or not. If yes, then maybe you
might consider using the global_dc object.