This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR target/19933 and PR target/21315


Eric Botcazou wrote:
In fact, I'd go so far as to say that maybe we should have a list of
things that need to be fixed, not things that don't, on most platforms.


Is that not what the matching regexp is for?


 We've had at least two customers ask us to look through the fixes
being applied to system headers, and when we've looked we've found a lot
of things being fixed unnecessarily.  The unnecessary fixes have a cost
in that they increase the problems with upgrading the OS, but not the
compilers; you can rerurn fixincludes, but that's not trivial.


Would the solution to this problem not be to strengthen this regexp?

That's what we've done -- but the problem is that fixes are on by default. So, if someone adds a new fix, it may fire spuriously on my system. Or, if my system gets a new header, it may be spuriously fixed by an existing fix.


--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]