This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Pointer no escape attribute


On Tue, 10 May 2005, Daniel Berlin wrote:

> The first is the addition of the pointer no escape attribute, which is
> used on functions to inform the optimizers that a pointer won't escape
> the function we pass it to.

If this is meant to be user-visible then it needs documentation and 
testcases.  If not, it should have a name which is not a valid C 
identifier, as with the "no vops" attribute, so it cannot be specified in 
source code.

Diagnostics should now use %qE with an identifier in preference to %qs 
with IDENTIFIER_POINTER.

I don't see the relation of the c-typeck.c change to the new attribute.  
It needs its own testcase and justification.

In principle it seems to me this attribute should apply to function types 
rather than to function declarations.  Why is it being implemented as a 
decl attribute?  (If it is purely for built-in function then that would be 
one reason.)

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]