This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Add DFA-based pipeline descriptions for MIPS 24K core.


David Ung <davidu@mips.com> writes:
> On Fri, 2005-05-06 at 18:18 +0100, Richard Sandiford wrote:
>> David Ung <davidu@mips.com> writes:
>> > because of all the bypasses involving r24k_int_store will call the check
>> > on store_data_bypass_p which will fail on the above rtl.
>> > The above rtl don't qualify as a set.
>> 
>> OK, that's fine.  But please always give this sort of detail in comments!
>> Don't leave folks to guess.
>> 
>> The patch is OK provided you replace the comment:
>> 
>> ;; Unknown stores assumed to transfer integers.
>> (define_insn_reservation "r24k_unknown_store" 1 
>>   (and (eq_attr "cpu" "24k,24kx")
>>        (and (eq_attr "type" "store")
>> 	    (eq_attr "mode" "unknown")))
>>   "r24k_iss+r24k_ixu_arith")
>> 
>> with one which says that this reservation is specifically for cprestore
>> and is needed because the cprestore pattern does not have a normal
>> SET-of-MEM pattern.
>
> thanks.  I am attaching the revised 24k.md file.

Applied to mainline.  Thanks for the contribution, and for agreeing
to make the changes.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]