This is the mail archive of the
mailing list for the GCC project.
Re: [patch] Add DFA-based pipeline descriptions for MIPS 24K core.
David Ung <email@example.com> writes:
> because of all the bypasses involving r24k_int_store will call the check
> on store_data_bypass_p which will fail on the above rtl.
> The above rtl don't qualify as a set.
OK, that's fine. But please always give this sort of detail in comments!
Don't leave folks to guess.
The patch is OK provided you replace the comment:
;; Unknown stores assumed to transfer integers.
(define_insn_reservation "r24k_unknown_store" 1
(and (eq_attr "cpu" "24k,24kx")
(and (eq_attr "type" "store")
(eq_attr "mode" "unknown")))
with one which says that this reservation is specifically for cprestore
and is needed because the cprestore pattern does not have a normal