This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++/middle-end patch PING] Visibility hidden (long standing) issues


On May 4, 2005, at 8:33 AM, Paolo Carlini wrote:
Can someone have a look to these issues/patches? The first pair (patch +
testcases) seems slightly less controversial, but it's a complex tangle,
please help figuring out which is the real issue/prospective fix, otherwise:


libstdc++/19664 (C++ part):
    http://gcc.gnu.org/ml/gcc-patches/2005-02/msg00180.html
    http://gcc.gnu.org/ml/gcc-patches/2005-02/msg00330.html

These look fine to me.


For the testcase, I think:

+proc is-shared-library-supported { } {
+    # Shared library is only supported on a couple of ELF platforms.
+    if { ![istarget hppa*64*-*-hpux*] \
+        && ![istarget hppa*-*-linux*] \
+        && ![istarget i?86-*-sysv4*] \
+        && ![istarget i?86-*-unixware] \
+        && ![istarget i?86-*-elf*] \
+        && ![istarget i?86-*-linux*] \
+        && ![istarget ia64-*-elf*] \
+        && ![istarget ia64-*-linux*] \
+        && ![istarget m68k-*-linux*] \
+        && ![istarget mips*-*-irix5*] \
+        && ![istarget mips*-*-linux*] \
+        && ![istarget powerpc-*-elf*] \
+        && ![istarget powerpc-*-linux*] \
+        && ![istarget powerpc-*-sysv4*] \
+        && ![istarget sparc*-*-elf] \
+        && ![istarget sparc*-*-solaris2*] \
+        && ![istarget sparc*-*-linux*] \
+        && ![istarget arm*-*-linux*] \
+        && ![istarget alpha*-*-linux*] \
+        && ![istarget s390*-*-linux*] \
+        && ![istarget x86_64-*-linux*] } {
+       return 0
+    }
+
+    if { [istarget *-*-linux*aout*] \
+        || [istarget *-*-linux*oldld*] } {
+       return 0
+    }
+
+    return 1
+}

should be more like:

+proc is-shared-library-supported { } {
+    if { [istarget *-*-linux*aout*] \
+        || [istarget *-*-linux*oldld*] } {
+       return 0
+    }
+    # Shared library is only supported on a couple of ELF platforms.
+    if { [istarget hppa*64*-*-hpux*] \
+        || [istarget hppa*-*-linux*] \
+        || [istarget i?86-*-sysv4*] \
+        || [istarget i?86-*-unixware] \
+        || [istarget i?86-*-elf*] \
+        || [istarget i?86-*-linux*] \
+        || [istarget ia64-*-elf*] \
+        || [istarget ia64-*-linux*] \
+        || [istarget m68k-*-linux*] \
+        || [istarget mips*-*-irix5*] \
+        || [istarget mips*-*-linux*] \
+        || [istarget powerpc-*-elf*] \
+        || [istarget powerpc-*-linux*] \
+        || [istarget powerpc-*-sysv4*] \
+        || [istarget sparc*-*-elf] \
+        || [istarget sparc*-*-solaris2*] \
+        || [istarget sparc*-*-linux*] \
+        || [istarget arm*-*-linux*] \
+        || [istarget alpha*-*-linux*] \
+        || [istarget s390*-*-linux*] \
+        || [istarget x86_64-*-linux*] } {
+       return 1
+    }
+
+
+    return 0
+}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]