This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Add Ada tasking support for hppa-unknown-linux-gnu (take 2)
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: charlet at adacore dot com (Arnaud Charlet)
- Cc: gcc-patches at gcc dot gnu dot org, laurent at guerby dot net
- Date: Fri, 29 Apr 2005 20:10:37 -0400 (EDT)
- Subject: Re: [patch] Add Ada tasking support for hppa-unknown-linux-gnu (take 2)
> > 3) sigset_t changed to array of unsigned_long.
>
> Could you explain why you changed sigset_t definition ?
>From bits/sigset.h:
# define _SIGSET_NWORDS (1024 / (8 * sizeof (unsigned long int)))
typedef struct
{
unsigned long int __val[_SIGSET_NWORDS];
} __sigset_t;
> Also, the alignment for atomic_lock_t seems wrong to me: you are using
> 8 * 16, but the alignment is specified in *bytes*, not bits (a usual
> confusion), so this value seems very high to me. Didn't you mean 16
> instead ?
The required alignment is 16 bytes.
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)