This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Support ENTRY in FUNCTIONs (PR fortran/13082) (take 3)
Jakub Jelinek wrote:
> Below is updated patch, that incorporates your comments, add a gfortran.dg
> testcase for the cases where gfortran should issue errors and fixes a bug
> with entries/functions with implicit types (the only changes are in resolve.c
> and testcases).
Good catch WRT the implicit types.
I can't thoroughly review the part where you build the union, since I don't
know the handling of types in gcc well enough, but I'm convinced that you know
this stuff well enough, I verified that you're calling the right functions,
and so far noone else has jumped at you :-)
This is ok for mainline and 4.0, but since I'd appreciate it if Paul could
look over gfc_get_mixed_entry_union, I'd say wait a day or two, and if he
doesn't object by then, commit it. It's definitely an enhancement over what
we have now, and if there's a bug in gfc_get_mixed_entry_union it should only
require fixing there, so we're not messing up anything.
Thanks,
- Tobi