This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] tree-ssa-live.c: Use a heap-allocated array instead ofVARRAY (Part 2)


Kazu Hirata wrote:
Hi,

Attached is a patch to allocate partition_link and tpa_nodes on heap.

We do not change the sizes of these two arrays.  They don't "escape"
build_tree_conflict_graph, either.  So we can simply allocate these
two arrays on heap without using the updated VEC API.

Y'know, all things being equal, why not use the VEC API here? you'll get virtually the same code (using _VEC_quick_foo or whatever), and with checking enabled you're guaranteed not to go wandering off the end.

just my 2pennies.

nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::     CodeSourcery LLC
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]