This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix for reshape
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Thomas Koenig <Thomas dot Koenig at online dot de>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 19 Apr 2005 23:32:20 +0200
- Subject: Re: Fix for reshape
- References: <20050419204951.GA27578@meiner.onlinehome.de>
Thomas Koenig wrote:
> This fixes all runtime issues for reshape that I know of.
Very cool!
> OK for mainline (and for 4.0 once it's open)?
Yes, but you need to do essentially the same thing in the generic
implementation (that is the implementation for types whose size doesn't match
INTEGER*{4|8}), as well. See intrinsics/reshape_generic.c.
> ***************
> *** 129,136 ****
>
> if (pad)
> {
> - if (pad->dim[0].stride == 0)
> - pad->dim[0].stride = 1;
> pdim = GFC_DESCRIPTOR_RANK (pad);
> psize = 1;
> for (n = 0; n < pdim; n++)
> --- 151,156 ----
I'd prefer this to stay and the other one to go (keeping everything related to
pad in one place), but I don't feel very strongly about this.
- Tobi