This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Testsuite adaptions for AVR in gcc.c-torture/compile


Am Dienstag, 19. April 2005 00:30 schrieb Janis Johnson:
>
> Do you have an FSF copyright assignment?  I should have asked that
> question right away.
>
Yes.

> The default dg-do action for tests in gcc.c-torture/compile is
> 'assemble'.  There's no need to leave in 'dg-do assemble' by itself,
> and no reason to add 'dg-do compile' unless the test should not be
> assembled.
I thought that there is a requirement for a dg-do comment before
one could make use of the other keywords. I have now removed the 
"dg-do"s.

> Most of the tests you're changing to XFAIL should be skipped instead,
> but the support for skipping tests for specific options is quite new.
> A test should be an expected failure only if it fails due to a bug;
> if the functionality will never be supported for that target then it
> can be skipped instead.  In these tests, the existing xfails look to
> me as if they can be skips.
I now have used dg-skip-if for test cases where, e.g. memory requirement
is larger than possibly ever available but xfail if I think that in the future 
there might be processors with sufficient memory.

Yours,

Björn


2004-04-15 Bjoern Haase <bjoern.m.haase@web.de>

	* gcc.c-torture/compile/20001226-1.c: Clean up and skip avr-*-*,
	hc11,hc12 and xtensa.
	* gcc.c-torture/compile/20010226-1.c: Add effective target trampolines
	* gcc.c-torture/compile/nested-1.c: Ditto.
	* gcc.c-torture/compile/20050122-2.c: Ditto.
        * gcc.c-torture/compile/20011119-1.c: Add dg-require-alias
	* gcc.c-torture/compile/981001-2.c: Ditto.
	* gcc.c-torture/compile/20011119-2.c: Ditto.
	* gcc.c-torture/compile/20020604-1.c: Clean up and xfail avr-*-*
	* gcc.c-torture/compile/20010327-1.c: Ditto.
        * gcc.c-torture/compile/980506-1.c: Ditto.

Index: 20001226-1.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/20001226-1.c,v
retrieving revision 1.2
diff -C5 -r1.2 20001226-1.c
*** 20001226-1.c	13 Jun 2003 05:40:59 -0000	1.2
--- 20001226-1.c	19 Apr 2005 19:11:26 -0000
***************
*** 1,9 ****
  /* This does not assemble on m68hc11 because the function is larger
     than 64K.  */
! /* { dg-do assemble { xfail m6811-*-* m6812-*-* } } */
! /* { dg-xfail-if "jump beyond 128K not supported" "xtensa-*-*" "-O0" "" } */
  
  /* This testcase exposed two branch shortening bugs on powerpc.  */
  
  #define C(a,b) \
    if (a > b)  goto gt; \
--- 1,11 ----
  /* This does not assemble on m68hc11 because the function is larger
     than 64K.  */
! /* { dg-do assemble } */
! /* { dg-skip-if "jump beyond 128K not supported" "xtensa-*-*" "-O0" "" } */
! /* { dg-skip-if "too much code for avr" { "avr-*-*" } { "*" } { "" } } */
! /* { dg-skip-if "too much code" { "m6811-*-*" "m6812-*-*" } { "*" } { "" } } */
  
  /* This testcase exposed two branch shortening bugs on powerpc.  */
  
  #define C(a,b) \
    if (a > b)  goto gt; \
Index: 20010226-1.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/20010226-1.c,v
retrieving revision 1.1
diff -C5 -r1.1 20010226-1.c
*** 20010226-1.c	9 Jan 2002 21:34:30 -0000	1.1
--- 20010226-1.c	19 Apr 2005 19:11:26 -0000
***************
*** 1,5 ****
--- 1,7 ----
+ /* { dg-require-effective-target trampolines } */
+ 
  void f1 (void *);
  void f3 (void *, void (*)(void *));
  void f2 (void *);
  
  int foo (void *a, int b)
Index: 20010327-1.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/20010327-1.c,v
retrieving revision 1.5
diff -C5 -r1.5 20010327-1.c
*** 20010327-1.c	3 Mar 2003 19:02:28 -0000	1.5
--- 20010327-1.c	19 Apr 2005 19:11:26 -0000
***************
*** 2,9 ****
     that references addresses of size 'unsigned long', even if that's not
     the same as __SIZE_TYPE__.  (See 20011114-1.c for the same test of
     size __SIZE_TYPE__.)  
  
     Some rare environments might not have the required relocs to support
!    this; they should have this test disabled in the .x file.  */
  extern void _text;
  static unsigned long x = (unsigned long) &_text - 0x10000000L - 1;
--- 2,12 ----
     that references addresses of size 'unsigned long', even if that's not
     the same as __SIZE_TYPE__.  (See 20011114-1.c for the same test of
     size __SIZE_TYPE__.)  
  
     Some rare environments might not have the required relocs to support
!    this; they should have this test disabled by magic comments.  */
! 
! /* { dg-xfail-if "hi mode pointer for avr" { "avr-*-*" } { "*" } { "" } } */ 
! 
  extern void _text;
  static unsigned long x = (unsigned long) &_text - 0x10000000L - 1;
Index: 20011119-1.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/20011119-1.c,v
retrieving revision 1.2
diff -C5 -r1.2 20011119-1.c
*** 20011119-1.c	25 Mar 2002 20:55:20 -0000	1.2
--- 20011119-1.c	19 Apr 2005 19:11:27 -0000
***************
*** 1,4 ****
--- 1,6 ----
+ /* { dg-require-alias "" } */
+ 
  extern inline int foo (void) { return 23; }
  int xxx(void) __asm__("xxx");
  int xxx(void) { return 23; }
  extern int foo (void) __attribute__ ((weak, alias ("xxx")));
Index: 20011119-2.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/20011119-2.c,v
retrieving revision 1.2
diff -C5 -r1.2 20011119-2.c
*** 20011119-2.c	25 Mar 2002 20:55:20 -0000	1.2
--- 20011119-2.c	19 Apr 2005 19:11:27 -0000
***************
*** 1,5 ****
--- 1,6 ----
+ /* { dg-require-alias "" } */
  extern inline int foo (void) { return 23; }
  int bar (void) { return foo (); }
  extern int foo (void) __attribute__ ((weak, alias ("xxx")));
  int baz (void) { return foo (); }
  int xxx(void) __asm__("xxx");
Index: 20020604-1.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/20020604-1.c,v
retrieving revision 1.4
diff -C5 -r1.4 20020604-1.c
*** 20020604-1.c	23 Dec 2003 20:36:59 -0000	1.4
--- 20020604-1.c	19 Apr 2005 19:11:30 -0000
***************
*** 1,8 ****
! /* The array is too big. */
! /* { dg-xfail-if "The array too big" { "h8300-*-*" } { "-mno-h" "-mn" } { "" } } */
! /* { dg-do assemble { xfail m6811-*-* m6812-*-* } } */
  
  /* PR c/6957
     This testcase ICEd at -O2 on IA-32, because
     (insn 141 139 142 (set (subreg:SF (reg:QI 72) 0)
  	   (plus:SF (reg:SF 73)
--- 1,7 ----
! /* { dg-xfail-if "Array too big" { "m6811-*-*" "m6812-*-*" "avr-*-*" } { "*" } { "" } } */
! /* { dg-xfail-if "Array too big" { "h8300-*-*" } { "-mno-h" "-mn" } { "" } } */
  
  /* PR c/6957
     This testcase ICEd at -O2 on IA-32, because
     (insn 141 139 142 (set (subreg:SF (reg:QI 72) 0)
  	   (plus:SF (reg:SF 73)
Index: 20050122-2.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/20050122-2.c,v
retrieving revision 1.1
diff -C5 -r1.1 20050122-2.c
*** 20050122-2.c	22 Jan 2005 17:52:44 -0000	1.1
--- 20050122-2.c	19 Apr 2005 19:11:33 -0000
***************
*** 1,6 ****
--- 1,8 ----
  /* Related to PR 19484.  */
+ /* { dg-require-effective-target trampolines } */
+ 
  extern void foo (void) __attribute__((noreturn));
  int n;
  
  void
  g (void)
Index: 980506-1.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/980506-1.c,v
retrieving revision 1.5
diff -C5 -r1.5 980506-1.c
*** 980506-1.c	23 Dec 2003 20:36:59 -0000	1.5
--- 980506-1.c	19 Apr 2005 19:11:40 -0000
***************
*** 1,9 ****
  /* The arrays are too large for the xstormy16 - won't fit in 16 bits. */
  /* { dg-xfail-if "The array too big" { "h8300-*-*" } { "-mno-h" "-mn" } { "" } } */
- /* { dg-do assemble { xfail xstormy16-*-* m6811-*-* m6812-*-* } } */
- 
  unsigned char	TIFFFax2DMode[20][256];
  unsigned char	TIFFFax2DNextState[20][256];
  unsigned char	TIFFFaxUncompAction[20][256];
  unsigned char	TIFFFaxUncompNextState[20][256];
  unsigned char	TIFFFax1DAction[230][256];
--- 1,8 ----
  /* The arrays are too large for the xstormy16 - won't fit in 16 bits. */
+ /* { dg-xfail-if "Array too big" { "xstormy16-*-*" "m6811-*-*" "m6812-*-*" "avr-*-*" } { "*" } { "" } } */
  /* { dg-xfail-if "The array too big" { "h8300-*-*" } { "-mno-h" "-mn" } { "" } } */
  unsigned char	TIFFFax2DMode[20][256];
  unsigned char	TIFFFax2DNextState[20][256];
  unsigned char	TIFFFaxUncompAction[20][256];
  unsigned char	TIFFFaxUncompNextState[20][256];
  unsigned char	TIFFFax1DAction[230][256];
Index: 981001-2.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/981001-2.c,v
retrieving revision 1.2
diff -C5 -r1.2 981001-2.c
*** 981001-2.c	16 Dec 1998 22:10:22 -0000	1.2
--- 981001-2.c	19 Apr 2005 19:11:40 -0000
***************
*** 1,5 ****
--- 1,7 ----
+ /* { dg-require-alias "" } */
+ 
  #define weak_alias(func, aliasname) \
  	extern __typeof (func) aliasname __attribute__ ((weak, alias (#func)));
  
  #define add3(d, m, c) ((d) + (m) + (c))
  
Index: nested-1.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/nested-1.c,v
retrieving revision 1.1
diff -C5 -r1.1 nested-1.c
*** nested-1.c	15 Oct 2004 13:49:02 -0000	1.1
--- nested-1.c	19 Apr 2005 19:11:42 -0000
***************
*** 1,5 ****
--- 1,7 ----
+ /* { dg-require-effective-target trampolines } */
+ 
  typedef __SIZE_TYPE__ size_t;
  extern int printf (const char *, ...);
  extern void *memset (void *, int, size_t);
  
  int bar (int (*)(), int, void *);

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]