This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] New pragma handling mechanism.


Richard Henderson wrote:
On Tue, Apr 12, 2005 at 09:59:00PM -0700, Mark Mitchell wrote:

http://gcc.gnu.org/ml/gcc-patches/2005-04/msg00934.html

but, obviously, it was either unclear or not compelling.


Not particularly compelling. I think this is way over-engineered.

You say "over-engineered"; I say "modular". (I guess I'm no Irving Berlin.) All I can really say "I've done it this way, and it works nicely, and so this less-structured way seems risky to me."


How do you plan to represent a statement-level #pragma in a C++ template? It would be nice if the mechanism we have is general (rather than, say, setting PRAGMA_OMP_FOO on the statement), so that we can extend to other statement-level #pragmas in future. And, when you instantiate the template, you want to be able to re-use routines called at parse-time. How will that work?

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]