This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Revert controversial apply_{args,result}_size change


Eric Christopher wrote:

This last part is what doesn't agree with the analogous macro
FUNCTION_ARG_REGNO_P (which you'll agree is highly related to this).

I agree; I don't see any reason not to have a single convention for these sorts of macros.


What seems to have happened is that your change modified the behavior of the API used by back ends, but did not modify the back ends to compensate for that change. I think we should get back in synch, either by undoing your change, or by updating the back ends. I don't have a preference as to which approach is taken, though I suspect that undoing your change is easier, in that it probably requires auditing less code.

It would be, and I have no preference (other than that the current definition makes no sense if you look at it). My change was originally just going to be for apply_args_size, and does match the definition there - I just took it across to the similar function.

I'll make either change that's necessary, let's just come to an
agreement on what it should be. I think it should be like
FUNCTION_ARG_REGNO_P.

I think that's fine. I know Richard E. (who weighed in before) is travelling, so he may not be able to comment. I'd be interested in hear from Eric B., as to whether he's comfortable with your approach. (I think he's already done the SPARC back-end changes, consistent with the new definition, as has Richard E. for ARM.)


I'm not sure how much fun it will be to audit all the other back ends to try to see what needs to be done, but I agree that it would be more consistent to make this macro match F_A_R_P, so go for it! Don't forget to update the docs, too. :-)

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]