This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] gcse.c cleanups
- From: Roger Sayle <roger at eyesopen dot com>
- To: Steven Bosscher <stevenb at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 9 Apr 2005 19:57:04 -0600 (MDT)
- Subject: Re: [patch] gcse.c cleanups
On Sun, 10 Apr 2005, Steven Bosscher wrote:
>
> * cselib.c (clear_table): Rename to cselib_clear_table.
> * cselib.h (cselib_clear_table): Add prototype.
> * gcse.c (gcse_main): Make 'f' argument unused.
> (alloc_gcse_mem): Do not walk the insn chain, walk the contents
> of each basic block instead.
> (compute_sets, compute_hash_table_work): Likewise.
> (constprop_register): Change int 'alter_jumps' argument to bool.
> (do_local_cprop): Likewise.
> (local_cprop_pass): Likewise. Also walk basic blocks instead of
> the insn chain. Explicitly clear the cselib tables after finishing
> one basic block. Make sure there are no unterminated libcall blocks.
> Update compute_sets call.
> (cprop): Walk basic blocks instead of the insn chain.
> (one_cprop_pass, compute_ld_motion_mems, compute_store_table):
> Likewise.
> (bypass_jumps): Update alloc_gcse_mem, compute_sets, and
> one_cprop_pass calls.
All these clean-ups look good. Ok for mainline.
I'll preapprove a follow-up patch to remove the "f" argument from
gcse_main, and it's single caller in passes.c.
Thanks,
Roger
--