This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch] genattrtab.h: Remove four unused macros.
- From: Kazu Hirata <kazu at cs dot umass dot edu>
- To: gcc-patches at gcc dot gnu dot org
- Date: Fri, 08 Apr 2005 11:12:19 -0400 (EDT)
- Subject: [patch] genattrtab.h: Remove four unused macros.
Hi,
Attached is a patch to remove four unused macros.
ATTR_FUNC_UNITS
ATTR_BLOCKAGE
These two do not appear anywhere in the source code except in their
own definitions.
ATTR_NEGATIVE_OK
ATTR_UNSIGNED
These macros are used in conditionals, but they are never assigned
to variables.
They were introduced with
http://gcc.gnu.org/ml/gcc-cvs/2003-07/msg00362.html
The last real uses of these macros were moved by
http://gcc.gnu.org/ml/gcc-cvs/2004-07/msg01020.html
Tested on i686-pc-linux-gnu. OK to apply?
Kazu Hirata
2005-04-08 Kazu Hirata <kazu@cs.umass.edu>
* genattrtab.c (attr_desc): Remove negative_ok and unsigned_p.
(check_attr_value, write_attr_get, write_expr_attr_cache,
find_attr, make_internal_attr): Don't reference negative_ok or
unsigned_p.
* genattrtab.h (ATTR_NEGATIVE_OK, ATTR_UNSIGNED,
ATTR_FUNC_UNITS, ATTR_BLOCKAGE): Remove.
(ATTR_STATIC): Adjust the value.
Index: genattrtab.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/genattrtab.c,v
retrieving revision 1.156
diff -u -d -p -r1.156 genattrtab.c
--- genattrtab.c 5 Mar 2005 14:00:59 -0000 1.156
+++ genattrtab.c 8 Apr 2005 03:55:46 -0000
@@ -184,8 +184,6 @@ struct attr_desc
struct attr_value *default_val; /* Default value for this attribute. */
int lineno : 24; /* Line number. */
unsigned is_numeric : 1; /* Values of this attribute are numeric. */
- unsigned negative_ok : 1; /* Allow negative numeric values. */
- unsigned unsigned_p : 1; /* Make the output function unsigned int. */
unsigned is_const : 1; /* Attribute value constant for each run. */
unsigned is_special : 1; /* Don't call `write_attr_set'. */
unsigned static_p : 1; /* Make the output function static. */
@@ -967,7 +965,7 @@ check_attr_value (rtx exp, struct attr_d
break;
}
- if (INTVAL (exp) < 0 && ! attr->negative_ok)
+ if (INTVAL (exp) < 0)
{
message_with_line (attr->lineno,
"negative numeric value specified for attribute %s",
@@ -984,8 +982,6 @@ check_attr_value (rtx exp, struct attr_d
if (attr == 0 || attr->is_numeric)
{
p = XSTR (exp, 0);
- if (attr && attr->negative_ok && *p == '-')
- p++;
for (; *p; p++)
if (! ISDIGIT (*p))
{
@@ -1088,8 +1084,7 @@ check_attr_value (rtx exp, struct attr_d
have_error = 1;
}
else if (attr
- && (attr->is_numeric != attr2->is_numeric
- || (! attr->negative_ok && attr2->negative_ok)))
+ && attr->is_numeric != attr2->is_numeric)
{
message_with_line (attr->lineno,
"numeric attribute mismatch calling `%s' from `%s'",
@@ -3716,8 +3711,6 @@ write_attr_get (struct attr_desc *attr)
printf ("static ");
if (!attr->is_numeric)
printf ("enum attr_%s\n", attr->name);
- else if (attr->unsigned_p)
- printf ("unsigned int\n");
else
printf ("int\n");
@@ -3965,8 +3958,6 @@ write_expr_attr_cache (rtx p, struct att
if (!attr->is_numeric)
printf (" enum attr_%s ", attr->name);
- else if (attr->unsigned_p)
- printf (" unsigned int ");
else
printf (" int ");
@@ -4278,8 +4269,8 @@ find_attr (const char **name_p, int crea
attr = oballoc (sizeof (struct attr_desc));
attr->name = DEF_ATTR_STRING (name);
attr->first_value = attr->default_val = NULL;
- attr->is_numeric = attr->negative_ok = attr->is_const = attr->is_special = 0;
- attr->unsigned_p = attr->static_p = 0;
+ attr->is_numeric = attr->is_const = attr->is_special = 0;
+ attr->static_p = 0;
attr->next = attrs[index];
attrs[index] = attr;
@@ -4301,8 +4292,6 @@ make_internal_attr (const char *name, rt
attr->is_numeric = 1;
attr->is_const = 0;
attr->is_special = (special & ATTR_SPECIAL) != 0;
- attr->negative_ok = (special & ATTR_NEGATIVE_OK) != 0;
- attr->unsigned_p = (special & ATTR_UNSIGNED) != 0;
attr->static_p = (special & ATTR_STATIC) != 0;
attr->default_val = get_attr_value (value, attr, -2);
}
Index: genattrtab.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/genattrtab.h,v
retrieving revision 1.9
diff -u -d -p -r1.9 genattrtab.h
--- genattrtab.h 9 Jul 2003 00:44:34 -0000 1.9
+++ genattrtab.h 8 Apr 2005 03:55:46 -0000
@@ -51,8 +51,4 @@ extern void write_automata (void);
/* Flags for make_internal_attr's `special' parameter. */
#define ATTR_NONE 0
#define ATTR_SPECIAL (1 << 0)
-#define ATTR_NEGATIVE_OK (1 << 1)
-#define ATTR_UNSIGNED (1 << 2)
-#define ATTR_FUNC_UNITS (1 << 3)
-#define ATTR_BLOCKAGE (1 << 4)
-#define ATTR_STATIC (1 << 5)
+#define ATTR_STATIC (1 << 1)