Re: [patch] tree-ssa-sink.c: Don't restrict immediate uses that weconsider.

[Daniel Berlin <dberlin at dberlin dot org>]

On Thu, 2005-04-07 at 12:19 -0400, Daniel Berlin wrote:
> On Thu, 2005-04-07 at 10:37 -0400, Kazu Hirata wrote:
> > Hi,
> > 
> > Attached is a patch to teach nearest_common_dominator_of_uses not to
> > restrict the set of immediate uses that we consider.
> > 
> > nearest_common_dominator_of_uses goes through immediate uses to find a
> > location to sink a statement into.  It's important that we consider
> > all uses so that whatever location we come with dominates all uses.
> > It's dangerous to have an "if" statement to restrict the set of
> > immediate uses that we consider like so
> > 
> >   if (PHI_ARG_DEF (usestmt, idx) == var)
> > 
> > because the location that we come up with may not dominate all uses.
> > 
> You were the one who just added thi. :)
> 
> So doesn't this effectively just undo the patch you had come up with?
> 

Forget it, i see why it doesn't.
However, it is a partial reversion of your patch, which means you can
commit it yourself :)