This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: call for testers!
- From: Geoffrey Keating <geoffk at geoffk dot org>
- To: Kelley Cook <kcook at gcc dot gnu dot org>
- Cc: Christopher Faylor <" \"\"\"\"cgf\"\"@gcc.gnu.org"@geoffk.org>, gcc-patches at gcc dot gnu dot org
- Date: 05 Apr 2005 16:57:55 -0700
- Subject: Re: call for testers!
- References: <4252B2E0.7030201@gcc.gnu.org>
Kelley Cook <kcook@gcc.gnu.org> writes:
> > I'd really appreciate it if people on unusual host systems (AIX,
> > HPPA, cygwin, etc.) could see what the effect of the patch in
> > <http://gcc.gnu.org/ml/gcc-patches/2005-04/msg00145.html> is on
> > their bootstrap. I've gotten no responses at all, and I presume
> > this means that lots of people have tried the patch and discovered
> > that it works fine, or they aren't too worried about discovering
> > latent bugs and having their bootstrap fail...
>
> This fails on cygwin due do a comparison error in _chkstk.o.
>
> The cygwin.asm file gets preprocessed. Since the resulting .s file
> that actually gets sent to the assembler isn't explicitly specified in
> the makefile fragment, a temporary filename gets randomly generated.
>
> The comparison error comes from a difference in the debug name of the
> randomly generated temporary filename. The objectdumps of both files
> is the same.
>
> I'm assuming this would happen in a lot of places, so here is a patch
> to fix the problem by eliminating the creation of the temporary files
> by specifying "-pipe" in LIBGCC2_CFLAGS. Restrapped along with Geoff's
> patch on i686-pc-cygwin.
>
> OK to install?
>
> 2005-04-05 Kelley Cook <kcook@gcc.gnu.org>
>
> * Makefile.in (LIBGCC2_CFLAGS): Compile with -pipe.
Yes, this is OK, the problem is sufficiently widespread that this
looks like a good idea.
> --- ../../gcc-orig/gcc/Makefile.in 2005-03-31 11:38:25.000000000 -0500
> +++ Makefile.in 2005-04-05 11:09:07.471825900 -0400
> @@ -521,7 +521,9 @@
> # Options to use when compiling libgcc2.a.
> #
> LIBGCC2_DEBUG_CFLAGS = -g
> -LIBGCC2_CFLAGS = -O2 $(LIBGCC2_INCLUDES) $(GCC_CFLAGS) $(TARGET_LIBGCC2_CFLAGS) $(LIBGCC2_DEBUG_CFLAGS) $(GTHREAD_FLAGS) -DIN_LIBGCC2 -D__GCC_FLOAT_NOT_NEEDED @inhibit_libc@
> +LIBGCC2_CFLAGS = -O2 $(LIBGCC2_INCLUDES) $(GCC_CFLAGS) $(TARGET_LIBGCC2_CFLAGS) \
> + $(LIBGCC2_DEBUG_CFLAGS) $(GTHREAD_FLAGS) -pipe \
> + -DIN_LIBGCC2 -D__GCC_FLOAT_NOT_NEEDED @inhibit_libc@
>
> # Additional options to use when compiling libgcc2.a.
> # Some targets override this to -isystem include