This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Convert libiberty to use ISO C prototype style 5/n
On Sun, 27 Mar 2005, DJ Delorie wrote:
> Note that for some imported files, there were other reasons to stop
> importing. Regex, for example, was completely changed in glibc and
> now spans many files, so "just importing" it would have been
> inappropriate. In addition, glibc files aren't as portable as you'd
> expect, and it's sometimes difficult to get bugfixes approved there if
> they aren't bugs for Linux. For some files, there are multiple
> "masters" to choose from (sigh) like gnulib, glibc, etc.
>
> We'd have to consider each libiberty file on a case by case basis.
I think in most cases gnulib is the appropriate master, as it has similar
goals to libiberty. When files are imported individually, the
corresponding headers in include/ (if any) also need importing, and local
changes made in libiberty since the last import need auditing to see if
any should be preserved and merged back to gnulib.
One thing to watch for is that gnulib systematically converts LGPL files
to GPL whereas libiberty has a mixture of GPL and LGPL. I don't know
whether for any files for which an import makes sense it is significant
that LGPL rather than GPL is used.
I think the possibility of such imports (e.g. for obstack) is the main
advantage of converting libiberty to C90.
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
jsm@polyomino.org.uk (personal mail)
joseph@codesourcery.com (CodeSourcery mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)